Snapchat add account info #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Account name and ID for the stg_snapchat_ads.sql model
Corrected Account ID data type for union. Google Ads was numeric and was called first in the union on a test scenario. this broke other account id's that were varchar. casted to string using dbt_utils type_string function.
|
Thanks so much for opening this PR @csoule-shaker! I'll take a look at this first thing in the morning tomorrow and will let you know if I have any comments on your updates 😄 |
fivetran-joemarkiewicz
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Thanks so much for creating this PR @csoule-shaker! Your contributions are greatly appreciated by myself and the community of other individuals using this package! These updates look good and succeed my local tests! 🎉
There are a few minor updates I will make (eg. Updating the CHANGELOG and version numbers as well as trying to apply the same updates you did to Pinterest if possible) before merging to main.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Chris Soule, Data Architect InterWorks
What change(s) does this PR introduce?
Adds the Account information to the Ad_Reporting model for Snapchat
Does this PR introduce a breaking change?
Is this PR in response to a previously created Issue
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.