Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-union-schema #103

Merged
merged 20 commits into from
Oct 13, 2023
Merged

feature/add-union-schema #103

merged 20 commits into from
Oct 13, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Sep 18, 2023

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • 1.7.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

Tested on all packages that the source_relations were getting populated. See ticket for link to validation.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

❗ Special Updates for Ad Reporting ❗

To reduce integration testing time, not all models should be enabled in the run_models.sh vars. Update the variables after dbt run and dbt test to set:

  • this PR's package to true --> I chose a few packages since this update affects all. Tested every package in the validation.
  • Google Ads and Facebook Ads to true (if not already)
  • All other packages to false

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

📈

@fivetran-catfritz fivetran-catfritz self-assigned this Sep 18, 2023
@fivetran-catfritz fivetran-catfritz changed the title feature/add-union-schema) feature/add-union-schema Sep 21, 2023
@fivetran-catfritz fivetran-catfritz linked an issue Sep 21, 2023 that may be closed by this pull request
4 tasks
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz I just have a few comments to be addressed before this will be all clear!

I will also want to hold off approving this until all upstream changes are approved.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz this is looking great! I have been able to run locally and the results are as expected! I do have a few final comments before this will be ready to merge, but the bulk of the PR is approved! Additionally, would you be able to resolve the remaining merge conflicts.

Let me know if you have questions about my remaining comments and then we can discuss rollout tomorrow!

CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
models/semantic_models/ad_reporting__ad_report.yml Outdated Show resolved Hide resolved
@fivetran-catfritz fivetran-catfritz merged commit 200e4f3 into main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support multiple connectors from the same source
2 participants