-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/add-union-schema #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz I just have a few comments to be addressed before this will be all clear!
I will also want to hold off approving this until all upstream changes are approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz this is looking great! I have been able to run locally and the results are as expected! I do have a few final comments before this will be ready to merge, but the bulk of the PR is approved! Additionally, would you be able to resolve the remaining merge conflicts.
Let me know if you have questions about my remaining comments and then we can discuss rollout tomorrow!
bf58029
to
7777e29
Compare
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run –full-refreshdbt run –vars (if applicable)Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Tested on all packages that the
source_relations
were getting populated. See ticket for link to validation.Standard Updates
Please acknowledge that your PR contains the following standard updates:
DECISIONLOG updates have been updated (if applicable)❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the
run_models.sh
vars. Update the variables afterdbt run
anddbt test
to set:true
--> I chose a few packages since this update affects all. Tested every package in the validation.true
(if not already)All other packages tofalse
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📈