Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodeclass ref wrong docs #18

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix nodeclass ref wrong docs #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
273135f
fix nodeclass ref
Aug 28, 2024
096b4fe
fix other stuff
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/karpenter_nodes/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: karpenter_nodes
version: 1.1.3
version: 1.1.4
description: A Helm chart for generating NodeClasses and NodePools for Karpenter
maintainers:
- name: nadavbuc
2 changes: 1 addition & 1 deletion charts/karpenter_nodes/examples/argocd_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
sources:
- repoURL: 'https://opensource.fiverr.com/public_charts/'
chart: karpenter_nodes
targetRevision: 1.1.3
targetRevision: 1.1.4
helm:
valueFiles:
- $values/karpenter_nodes/eks-dev/common.yaml
Expand Down
16 changes: 8 additions & 8 deletions charts/karpenter_nodes/examples/output/output.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ spec:
spec:
nodeClassRef:
name: nodes-canary-amd64
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down Expand Up @@ -1179,7 +1179,7 @@ spec:
spec:
nodeClassRef:
name: nodes-cilium-managed-amd64
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down Expand Up @@ -1266,7 +1266,7 @@ spec:
spec:
nodeClassRef:
name: nodes-default-amd64
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
requirements:
- key: "karpenter.k8s.aws/instance-category"
Expand Down Expand Up @@ -1433,7 +1433,7 @@ spec:
spec:
nodeClassRef:
name: nodes-gpu-amd64
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down Expand Up @@ -1507,7 +1507,7 @@ spec:
spec:
nodeClassRef:
name: nodes-ingress-multiarch
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down Expand Up @@ -1585,7 +1585,7 @@ spec:
spec:
nodeClassRef:
name: nodes-jobs-amd64
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down Expand Up @@ -1665,7 +1665,7 @@ spec:
spec:
nodeClassRef:
name: nodes-monitoring-multiarch
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down Expand Up @@ -1737,7 +1737,7 @@ spec:
spec:
nodeClassRef:
name: nodes-workers-amd64
apiVersion: karpenter.sh/v1
group: karpenter.k8s.aws
kind: EC2NodeClass
taints:
- key: dedicated
Expand Down
2 changes: 1 addition & 1 deletion charts/karpenter_nodes/templates/nodepool.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
{{- $v.nodeClassRef | toYaml | nindent 8 }}
{{- else }}
name: {{ $k }}-{{ $v.instances.architecture | default $.Values.instances.architecture }}
apiVersion: karpenter.sh/{{ $.Values.ApiVersion }}
group: karpenter.k8s.aws
kind: EC2NodeClass
{{- end }}
{{- if or (hasKey $v "taints") (eq ($v.autoTaint | default $.Values.autoTaint) "true") }}
Expand Down
Loading