Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VYMCA-66] Zoom embed #72

Merged
merged 2 commits into from
Aug 4, 2020
Merged

[VYMCA-66] Zoom embed #72

merged 2 commits into from
Aug 4, 2020

Conversation

hamrant
Copy link

@hamrant hamrant commented Aug 3, 2020 •
edited
Loading

Steps for review:

screenshot-zoom us-2020 08 03-13_32_55

  • Create meeting on zoom and copy link for join

screenshot-zoom us-2020 08 03-16_23_40

  • Login as admin to the build/demo
  • Go to /events page
  • Edit any "Virtual Meeting" and use link from zoom
  • Go to the application and open "Virtual Meeting" page (Note: switch to HTTPS - otherwise you will have issues with microphone)
  • Check that you can see zoom iframe

screenshot-rose openy docksal-2020 08 03-16_27_03

  • Click on "join from your browser." link, enter the name and allow using of your microphone
  • After this you should see the meeting on the "Virtual Meeting" page
  • Check other "Virtual Meeting" pages without zoom link - the should show the only link as before this PR

@hamrant hamrant self-assigned this Aug 3, 2020
@fjbot
Copy link

fjbot commented Aug 3, 2020

Build 249
Build failed.
See http://ci.fivejars.com:8080/job/OPENY_GC_PR/249/display/redirect for details.

@hamrant
Copy link
Author

hamrant commented Aug 3, 2020

retest this please

@fjbot
Copy link

fjbot commented Aug 3, 2020

Build 251

Find the builds:
http://pr-72.openy-gated-content.ci.fivejars.com
http://rose.pr-72.openy-gated-content.ci.fivejars.com
http://lily.pr-72.openy-gated-content.ci.fivejars.com
http://carnation.pr-72.openy-gated-content.ci.fivejars.com

@AndreyMaximov AndreyMaximov changed the title [VYMCA-64] Zoom embed [VYMCA-66] Zoom embed Aug 3, 2020
@hamrant hamrant merged commit 5256cd2 into master Aug 4, 2020
@hamrant hamrant deleted the VYMCA-66 branch August 4, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anpolimus anpolimus anpolimus approved these changes

@AndreyMaximov AndreyMaximov Awaiting requested review from AndreyMaximov

Assignees

@hamrant hamrant

Labels
FiveJars REVIEWED TESTED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamrant @fjbot @anpolimus