Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled personify error message + new membership check logic #71

Merged
merged 10 commits into from
Jul 31, 2020
Merged

Styled personify error message + new membership check logic #71

merged 10 commits into from
Jul 31, 2020

Conversation

retif
Copy link

@retif retif commented Jul 31, 2020

No description provided.

@fjbot
Copy link

fjbot commented Jul 31, 2020

Build 244
Coding standards checks failed.
See http://ci.fivejars.com:8080/job/OPENY_GC_PR/244/display/redirect

@fjbot
Copy link

fjbot commented Jul 31, 2020

Build 244
Build failed.
See http://ci.fivejars.com:8080/job/OPENY_GC_PR/244/display/redirect for details.

@fjbot
Copy link

fjbot commented Jul 31, 2020

Build 245
Coding standards checks failed.
See http://ci.fivejars.com:8080/job/OPENY_GC_PR/245/display/redirect

@fjbot
Copy link

fjbot commented Jul 31, 2020

Build 245
Build failed.
See http://ci.fivejars.com:8080/job/OPENY_GC_PR/245/display/redirect for details.

anpolimus
anpolimus previously approved these changes Jul 31, 2020
@anpolimus anpolimus changed the title style personify auth error with retry button Styled personify error message + new membership check logic Jul 31, 2020
return FALSE;
}
$body = '<StoredProcedureRequest>
<StoredProcedureName>YSV_OpenY_Member_Access</StoredProcedureName>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now only Silicon Valley can do SSO?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed between You, me and SV team that we should have the same approach in the checking of membership status by using a custom procedure everywhere.
We Can change it to the OpenY_Member_Access, but in general it was approved as new approach for checking.
If this not a strategy for now, we have to understand how to organize this check.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anpolimus could you share SQL procedure in README then?
I'm fine with it, just wanted to make it flexible

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have that SQL. I was introduced to API request details only.
I'll ask YMCASV team to share it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked them in the letter.

@hamrant hamrant merged commit 4bc5a07 into fivejars:master Jul 31, 2020
@retif retif added TESTED and removed NEEDS REVIEW labels Feb 25, 2021
@retif retif added the REVIEWED label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants