-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styled personify error message + new membership check logic #71
Conversation
Activity logger + Custom auth verification
Build 244 |
Build 244 |
Build 245 |
Build 245 |
return FALSE; | ||
} | ||
$body = '<StoredProcedureRequest> | ||
<StoredProcedureName>YSV_OpenY_Member_Access</StoredProcedureName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now only Silicon Valley can do SSO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed between You, me and SV team that we should have the same approach in the checking of membership status by using a custom procedure everywhere.
We Can change it to the OpenY_Member_Access, but in general it was approved as new approach for checking.
If this not a strategy for now, we have to understand how to organize this check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anpolimus could you share SQL procedure in README then?
I'm fine with it, just wanted to make it flexible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have that SQL. I was introduced to API request details only.
I'll ask YMCASV team to share it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked them in the letter.
...les/openy_gc_auth/modules/openy_gc_auth_personify/src/Controller/PersonifyAuthController.php
Outdated
Show resolved
Hide resolved
...les/openy_gc_auth/modules/openy_gc_auth_personify/src/Controller/PersonifyAuthController.php
Outdated
Show resolved
Hide resolved
…roller/PersonifyAuthController.php
No description provided.