Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual tracking #69

Merged
merged 42 commits into from
Jul 28, 2020
Merged

Virtual tracking #69

merged 42 commits into from
Jul 28, 2020

Conversation

anpolimus
Copy link

@anpolimus anpolimus commented Jul 27, 2020 •
edited
Loading

Logging functionality for Virtual Y.
We've implemented it as a separate module that could be enabled/disabled anytime.

  • Enable openy_gc_log module
  • Log in to the system
  • open different content at Virtual Y
  • go to /admin/virtual-y-logs and verify that tracking of Virtual Y events works.

podarok and others added 24 commits July 6, 2020 13:08
@podarok
Merge pull request #5 from fivejars/master
7934835 
Latest progress
@podarok
Merge pull request #6 from fivejars/master
ead77d9 
Migration fixes + small improvements
@podarok
Finish renaming
2d5860c
@podarok
Rename all Gated to Virtul Y
c133d13
@anpolimus
Merge pull request #7 from ymcatwincities/rename
31feeba 
Rename all Gated to Virtual Y
@froboy
Tweak formatting of CSV file upload instructions
4a82c06
@podarok
Merge pull request #9 from froboy/patch-1
088bbe2 
Tweak formatting of CSV file upload instructions
@anpolimus
Merge pull request #8 from fivejars/master
eabee17 
Small fixes
@retif
compile js bundle in production mode
0d7c48c
@retif
telemetry
f026c7c
@retif
logger
1b6d241
@retif
logger
f8d9919
@retif
logger
5de2838
@retif
logger
0d5bb50
@retif
logger
d41545b
@retif
logger
ef4a89f
@retif
logger admin page line
b477082
@retif
logs datepicker added
5661697
@retif
logger views format comment
d630eaa
@retif
logger js behavior
820a2ca
@retif
Review fixes
5deafa6
@anpolimus
Merge pull request #5 from retif/telemetry
73e43fc 
Telemetry
@anpolimus
Fixed reporting table
44adc92
@anpolimus
Changed Virtual Y module description to more readable
69851a8
hamrant
hamrant suggested changes Jul 27, 2020
View reviewed changes
Copy link

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need Enable logging setting in openy_gated_content.settings.yml and base this setting enable/disable logging in the application.

@fjbot
Copy link

fjbot commented Jul 27, 2020

Build 229
Coding standards checks failed.
See http://ci.fivejars.com:8080/job/OPENY_GC_PR/229/display/redirect

@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@AndreyMaximov
Copy link

@anpolimus hi.
Please check http://ci.fivejars.com:8080/blue/organizations/jenkins/OPENY_GC_PR/detail/OPENY_GC_PR/229/pipeline for the PHPCS report

@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fivejars fivejars deleted a comment from AndreyMaximov Jul 27, 2020
@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fivejars fivejars deleted a comment from fjbot Jul 27, 2020
@fjbot
Copy link

fjbot commented Jul 27, 2020

Build 238

Find the builds:
http://pr-69.openy-gated-content.ci.fivejars.com
http://rose.pr-69.openy-gated-content.ci.fivejars.com
http://lily.pr-69.openy-gated-content.ci.fivejars.com
http://carnation.pr-69.openy-gated-content.ci.fivejars.com

@fivejars fivejars deleted a comment from fjbot Jul 28, 2020
@fivejars fivejars deleted a comment from fjbot Jul 28, 2020
hamrant
hamrant previously approved these changes Jul 28, 2020
View reviewed changes
anpolimus added 2 commits July 28, 2020 12:19
@anpolimus
Merge branch 'master' of github.com:fivejars/openy_gated_content
cc77e63 
# Conflicts:
#	js/gated-content/dist/gated-content.umd.min.js
@anpolimus
Rebuilt app
1cee488
@hamrant hamrant merged commit ea4f604 into fivejars:master Jul 28, 2020
@fjbot
Copy link

fjbot commented Jul 28, 2020

Build 240

Find the builds:
http://pr-69.openy-gated-content.ci.fivejars.com
http://rose.pr-69.openy-gated-content.ci.fivejars.com
http://lily.pr-69.openy-gated-content.ci.fivejars.com
http://carnation.pr-69.openy-gated-content.ci.fivejars.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podarok podarok podarok requested changes

@hamrant hamrant hamrant approved these changes

Assignees

@anpolimus anpolimus

Labels
IXM REVIEWED TESTED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anpolimus @fjbot @AndreyMaximov @podarok @hamrant @froboy @retif