Correct the suggested input instruction on the Activity Log filtering controls #318
Conversation
bring fork up to date with fivejars 1.4
|
Build 2919 |
|
Build 2919 |
|
retest |
| $config_dir .= '/config/install/'; | ||
| $config_importer = \Drupal::service('openy_upgrade_tool.importer'); | ||
| $config_importer->setDirectory($config_dir); | ||
| $config_importer->importConfigs([ |
There was a problem hiding this comment.
@TomScarboroughYMCA why do you want to comment this code?
There was a problem hiding this comment.
To be honest - I completely cut and pasted the _update blocks I found above this one, which had those comments. I don't have strong feelings on it.
There was a problem hiding this comment.
@anpolimus can you please clarify your question? The docblock is required as per coding standards, but is there another comment that should go away?
There was a problem hiding this comment.
@froboy, @TomScarboroughYMCA sorry. I've enabled dark mode at my Github and it was looking like you have commented code of the hook_update.
SOrry.
Everything is fine.
|
Build 2935 |
|
Build 2935 |
|
retest |
|
Tested. Testing is passed. |
Related Issue/Ticket:
PLEASE CHECK BASE BRANCH FOR YOUR PR
ONLY urgent and approved fixes for point release should go to master branch
ymcatwincities#119
Steps to test:
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_Nor other means.team in Slack