Fix duplicate logs in export files #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpolimus
approved these changes
Mar 20, 2021
hamrant
reviewed
Mar 21, 2021
| @@ -36,7 +36,9 @@ function openy_gc_log_preprocess_views_view(array &$variables) { | |||
| * Implements hook_cron(). | |||
| */ | |||
| function openy_gc_log_cron() { | |||
| \Drupal::service("openy_gc_log.log_archiver")->archive(); | |||
| $archiver = \Drupal::service("openy_gc_log.log_archiver"); | |||
| $archiver->setWorkerChunkSize(600); | |||
There was a problem hiding this comment.
I will change this to a setting, that can be modified in .settings.php
|
retest |
|
Testing passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Ticket:
PRODDEV-263
Additional change in this PR is related to
if (!isset($start) && !isset($end)) { $query->range(0, self::WORKER_CHUNK_SIZE); }This code was not reachable, so I changed the way this limit works by introducing new function setWorkerChunkSize which is called from cron handler.
Steps to test:
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_Nor other means.team in Slack