Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRODDEV-187] Group activity logs by day for user #286

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

NightHunterSV
Copy link

@NightHunterSV NightHunterSV commented Mar 1, 2021

https://openy.atlassian.net/browse/PRODDEV-187

Steps to test:

  • Log in as an admin and enable the Open Y Virtual YMCA Log module

  • (optionally) Change the granularity setting from 10 mins to 5 min
    image

  • Go to /virtual-ymca and navigate through the VY, run some videos, etc.

  • In another browser log in as a dummy user and navigate through the VY, run some videos, etc.

  • Wait for the time interval needed to create different activity logging records.

  • Again make some actions in the VY

  • Ensure there are few records for your account(s) on the Virtual Y logs tab
    image

  • Ensure the records are combined by day for the user on the Activity report tab
    image

  • Export logs manually and ensure a separate file was created for activity logs, with a total activity per day per user
    image
    image

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
  • Front-end fixes should be tested against all of the Open Y Themes.
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

Copy link

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok

@hamrant
Copy link

hamrant commented Mar 2, 2021

retest

@hamrant hamrant requested a review from AnastasiiaPys March 2, 2021 12:31
@fivejars fivejars deleted a comment from fjbot Mar 2, 2021
@AnastasiiaPys
Copy link

Tested, looks good for me.

@hamrant hamrant merged commit 5928690 into 1.3 Mar 2, 2021
@hamrant hamrant deleted the PRODDEV-187 branch March 2, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants