forked from ymcatwincities/openy_gated_content
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration bug on livestream teaser and change date library to dayjs #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
hamrant
previously approved these changes
Feb 24, 2021
Fix for builds in #278 |
anpolimus
previously approved these changes
Feb 25, 2021
hamrant
approved these changes
Feb 25, 2021
Tested, all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue/Ticket:
Live Stream and Virtual Meeting duration were displayed not precise enough using moment.humanize method(for example 45 minutes it is displayed as one hour).
While fixing this problem I am also replaced momentjs with dayjs which has almost the same API, but in 2kb package, so this PR also solves the problem of unreasonable bundle size used by moments library.
Steps to test:
created based on #275
Quality checks:
Please check these boxes to confirm this PR covers the following cases:
hook_update_N
or other means.team in Slack