Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration bug on livestream teaser and change date library to dayjs #277

Merged
merged 10 commits into from
Feb 25, 2021
Merged

Duration bug on livestream teaser and change date library to dayjs #277

merged 10 commits into from
Feb 25, 2021

Conversation

retif
Copy link

@retif retif commented Feb 24, 2021

Related Issue/Ticket:

Live Stream and Virtual Meeting duration were displayed not precise enough using moment.humanize method(for example 45 minutes it is displayed as one hour).
While fixing this problem I am also replaced momentjs with dayjs which has almost the same API, but in 2kb package, so this PR also solves the problem of unreasonable bundle size used by moments library.

Steps to test:

  • Check dates and duration displayed on live stream, virtual meeting and video teaser
  • Check dates and duration displayed on live stream, virtual meeting and video page

created based on #275

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@fivejars fivejars deleted a comment from fjbot Feb 24, 2021
hamrant
hamrant previously approved these changes Feb 24, 2021
@fivejars fivejars deleted a comment from fjbot Feb 24, 2021
@fivejars fivejars deleted a comment from retif Feb 24, 2021
@fivejars fivejars deleted a comment from fjbot Feb 24, 2021
@hamrant
Copy link

hamrant commented Feb 24, 2021

Fix for builds in #278

@fivejars fivejars deleted a comment from retif Feb 24, 2021
anpolimus
anpolimus previously approved these changes Feb 25, 2021
@retif retif dismissed stale reviews from anpolimus and hamrant via 0fad054 February 25, 2021 12:15
@fivejars fivejars deleted a comment from fjbot Feb 25, 2021
@fivejars fivejars deleted a comment from fjbot Feb 25, 2021
@fivejars fivejars deleted a comment from fjbot Feb 25, 2021
@fivejars fivejars deleted a comment from retif Feb 25, 2021
@fivejars fivejars deleted a comment from fjbot Feb 25, 2021
@fivejars fivejars deleted a comment from fjbot Feb 25, 2021
@fivejars fivejars deleted a comment from fjbot Feb 25, 2021
@AnastasiiaPys
Copy link

Tested, all good!

@AnastasiiaPys AnastasiiaPys merged commit cecc3c6 into fivejars:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants