Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added youtube player attributes handler #262

Merged
merged 9 commits into from
Mar 22, 2021
Merged

Added youtube player attributes handler #262

merged 9 commits into from
Mar 22, 2021

Conversation

kairamkondarajesh
Copy link

ymcatwincities#104

If a video is from YouTube, we need to check the related videos from the same author.

@froboy
Copy link

froboy commented Feb 8, 2021

@kairamkondarajesh when you update JS you need to commit a built version as well. Please run npm install then npm run build from js/gated_content.

@anpolimus
Copy link

@kairamkondarajesh thanks for your PR. It is great that player-vars were fixed in the npm package that we are serving.
Please fix build and we are ready to move forward.

@anpolimus anpolimus changed the base branch from master to 1.3 February 9, 2021 06:57
@anpolimus
Copy link

@kairamkondarajesh please remember that all changes instead of hotfixes should go to the release branches.
The current release branch is: 1.3
I've switched the base of this PR for you.
cc @froboy

@froboy
Copy link

froboy commented Feb 9, 2021

@anpolimus is it normal that this PR is showing other changes even though the target branch has been merged in?

@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@fivejars fivejars deleted a comment from fjbot Feb 9, 2021
@hamrant hamrant requested a review from anpolimus February 9, 2021 15:16
@anpolimus
Copy link

@kairamkondarajesh may I ask you to rebuild app again?

@kairamkondarajesh
Copy link
Author

@kairamkondarajesh may I ask you to rebuild app again?

@anpolimus I have run rebuild and committed the code. Please review.

@anpolimus
Copy link

retest

@hamrant
Copy link

hamrant commented Mar 22, 2021

retest

@fivejars fivejars deleted a comment from AnastasiiaPys Mar 22, 2021
@fivejars fivejars deleted a comment from fjbot Mar 22, 2021
@fivejars fivejars deleted a comment from fjbot Mar 22, 2021
@fivejars fivejars deleted a comment from fjbot Mar 22, 2021
@fivejars fivejars deleted a comment from fjbot Mar 22, 2021
@AnastasiiaPys
Copy link

Tested. Testing passed.

@AnastasiiaPys AnastasiiaPys merged commit 4151bcc into fivejars:1.3 Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants