-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added youtube player attributes handler #262
Added youtube player attributes handler #262
Conversation
@kairamkondarajesh when you update JS you need to commit a built version as well. Please run |
@kairamkondarajesh thanks for your PR. It is great that player-vars were fixed in the npm package that we are serving. |
@kairamkondarajesh please remember that all changes instead of hotfixes should go to the release branches. |
@anpolimus is it normal that this PR is showing other changes even though the target branch has been merged in? |
@kairamkondarajesh may I ask you to rebuild app again? |
@anpolimus I have run rebuild and committed the code. Please review. |
retest |
retest |
Tested. Testing passed. |
ymcatwincities#104
If a video is from YouTube, we need to check the related videos from the same author.