Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s informer to work with specific namespaces for logger #2647

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

shubham-bansal96
Copy link
Contributor

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #2647 (7a70792) into main (526b5f0) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
- Coverage   19.76%   19.70%   -0.06%     
==========================================
  Files          63       63              
  Lines        7179     7200      +21     
==========================================
  Hits         1419     1419              
- Misses       5656     5677      +21     
  Partials      104      104              
Flag Coverage Δ
unittests 19.70% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/informer.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake sanketsudake merged commit 918214c into main Nov 30, 2022
@sanketsudake sanketsudake deleted the informer-changes-logger branch December 1, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants