Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Kafka Client in Kafka Connector #2630

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

sanketsudake
Copy link
Member

@sanketsudake sanketsudake commented Nov 21, 2022

Signed-off-by: Sanket Sudake sanketsudake@gmail.com

Description

  • Set message lag count when subscribe created first time
  • Create single Kafka Client for all Kafka producers and consumers

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #2630 (667ffa0) into main (1e0641d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2630   +/-   ##
=======================================
  Coverage   19.60%   19.60%           
=======================================
  Files          63       63           
  Lines        7131     7131           
=======================================
  Hits         1398     1398           
  Misses       5629     5629           
  Partials      104      104           
Flag Coverage Δ
unittests 19.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake sanketsudake merged commit 8a3d8a4 into main Nov 28, 2022
@sanketsudake sanketsudake deleted the kafka-refactoring branch December 1, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant