Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tests #17

Merged
merged 4 commits into from
Feb 21, 2020
Merged

refactor: tests #17

merged 4 commits into from
Feb 21, 2020

Conversation

fisker
Copy link
Owner

@fisker fisker commented Feb 21, 2020

No description provided.

@pull-assistant
Copy link

pull-assistant bot commented Feb 21, 2020

Score: 0.88

Best reviewed: commit by commit


Optimal code review plan (1 warning)

refactor: tests

tests/main.js 80% changes removed in refactor: fixtures

     style: fix

     refactor: fixtures

     chore: add comment

Powered by Pull Assistant. Last update db0f609 ... d6f3984. Read the comment docs.

@fisker
Copy link
Owner Author

fisker commented Feb 21, 2020

Codecov Report

Merging #17 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           46        44    -2     
=========================================
- Hits            46        44    -2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01af73...db0f609. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #17 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         3    -1     
  Lines           46        42    -4     
=========================================
- Hits            46        42    -4     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01af73...d6f3984. Read the comment docs.

@todo
Copy link

todo bot commented Feb 21, 2020

move to integration test

// TODO: move to integration test
const importEsm = require('../..')
module.exports = importEsm('./bar.mjs')


This comment was generated by todo based on a TODO comment in 48819a6 in #17. cc @fisker.

@fisker fisker merged commit 5517b68 into master Feb 21, 2020
@todo todo bot mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants