Add avatars and display names #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karolk99
force-pushed
the
add-avatars-and-display-name
branch
from
564712a
to
fa79af1
Compare
Rados13
approved these changes
Apr 17, 2024
lib/pipeline.ex
Outdated
Comment on lines
252
to
262
| defp register_image_action(image_url) do | ||
| register_image = { | ||
| :lc_request, | ||
| %{ | ||
| type: "register", | ||
| entity_type: "image", | ||
| asset_type: "png", | ||
| image_id: "avatar_png", | ||
| url: image_url | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we move it to compositor_utils.ex as all lc_request are there.
Karolk99
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Initial LL-HLS test commit * Review fixes * Connection manager initial commit (#3) * update paths * Review fixes pt2 * add moduledoc * update gitignore * add readme stub * fix typo * Review fixes pt3 * Backoff if track manifest request fails * add missing send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.