This repository has been archived by the owner on May 16, 2024. It is now read-only.
[MV-400] Add Jest and unit test workflow #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyman503
changed the title
skyman503
changed the title
graszka22
suggested changes
Apr 12, 2023
| return { | ||
| connect: async (): Promise<void> => { | ||
| return new Promise<void>((resolve) => { | ||
| resolve(); |
There was a problem hiding this comment.
can you put this in the mocks directory? also it's the same as joinRoom, so maybe de-duplicate this
src/__mocks__/index.tsx
Outdated
| // noop | ||
| }; | ||
|
|
||
| export enum VideoQuality { |
There was a problem hiding this comment.
is there some way to import this from the real index.tsx? we're going to forget to change this here
There was a problem hiding this comment.
Added import and export for all of the enums
src/__mocks__/index.tsx
Outdated
|
|
||
| export const useMembraneServer = NOOP; | ||
| export const useRoomParticipants = NOOP; | ||
| export const useCameraState = NOOP; |
There was a problem hiding this comment.
It would be better if the hooks returned objects with mocked data / functions. Users don't just call the hooks, they also read something from them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes introduces basic tests and github workflow. Following PRs will contain more unittests.