This repository has been archived by the owner on May 16, 2024. It is now read-only.
[MV-345] Add Leave room screen #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyman503
reviewed
Mar 30, 2023
|
|
||
| export const Typo = ({ | ||
| variant = 'body-big', | ||
| color = TextColors.darkText, | ||
| children, | ||
| style, |
There was a problem hiding this comment.
Are you sure that adding custom styling to Typo component is a good practice? I would have assumed that we should keep it clean from custom behaviour since it was predefined in the designs and all of the additional styling should be done around it using <View> components.
There was a problem hiding this comment.
<Typo> is just a wrapper around react's <Text> component that adds font styles. I think we should be able to add positioning etc just like in <Text> component. It would be easier that way and it won't break anything. I agree that more complicated components should be styled by parent.
| <View style={styles.content}> | ||
| <Image | ||
| style={styles.logo} | ||
| source={require('../../assets/images/Logo.png')} |
There was a problem hiding this comment.
Mby it's time for an @assets alias, wdyt?
skyman503
approved these changes
Mar 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rejoin button doesn't work on Android. It's caused by react navigation mounting Preview screen when navigating from Leave screen to Room screen. They're working on fixing that.
For now we'll workaround this by conditional rendering like described here: https://reactnavigation.org/docs/auth-flow/
We'll need to do this anyway to fix the header jump problem.