This repository has been archived by the owner on May 16, 2024. It is now read-only.
[MV-355] Add initial screen. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graszka22
suggested changes
Mar 21, 2023
| <BackgroundWrapper> | ||
| <View style={styles.content}> | ||
| <View style={styles.header}> | ||
| <Logo |
There was a problem hiding this comment.
You've put the whole logo as a font? Interesting :D Normally I'd just export it to png image
There was a problem hiding this comment.
Is it a bad thing? There are smaller logos that are basically an icon without ant text, so I assumed it will be fine.
There was a problem hiding this comment.
I don't know :D I'd lean towards a png, because it's easier to use (just an Image component) and more conventional. In terms of performance I haven't measured it but I guess png might be faster, it shouldn't matter much. In terms of quality font would win but the difference shouldn't be significant, especially if you provide 3 sizes of the logo.
There was a problem hiding this comment.
Changed to use png.
graszka22
approved these changes
Mar 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.