Expo modules #131
Expo modules #131
Conversation
|
@skyman503 If you have a while you can take a look at this PR, it shouldn't change much. Things that are not working yet:
Focus on the code in modules, those thousands lines of changes are mostly yarn.locks, generated boilerplate etc. |
| override fun definition() = ModuleDefinition { | ||
| Name("MembraneWebRTC") | ||
|
|
||
| Events( |
There was a problem hiding this comment.
What about moving that bug fix from ex-29 here, since after this changes are applied I'd have to redo my PR. So wdyt about mimicing my changes here, since it is pretty short and straight forward ?
| BuildableName = "MembraneExample.app" | ||
| BlueprintName = "MembraneExample" | ||
| ReferencedContainer = "container:MembraneExample.xcodeproj"> | ||
| BuildableName = "reactnativemembranewebrtcexample.app" |
There was a problem hiding this comment.
That might be the reason why there are 2 xcodeproj
There was a problem hiding this comment.
The reason is that in MembraneExample.xcodeproj and reactnativemembranewebrtcexample.xcodeproj there are files that are gitignored, when switching between branches those gitignored fils are left by git
so my suggestion would be to just remove those folders when switching branches or rename reactnativemembranewebrtcexample back to MembraneExample but I don't know if it's a good idea to touch it 😅
example/src/screens/Preview.tsx
Outdated
| @@ -65,6 +65,8 @@ export const Preview = ({ navigation, route }: Props) => { | |||
| await connectAndJoinRoom(); | |||
| navigation.navigate('Room'); | |||
| } catch (err) { | |||
| console.log('ERR2', err); | |||
| @@ -0,0 +1,4 @@ | |||
| export function isJest() { | |||
| // @ts-ignore | |||
|
As for the question in description in my opinion, as long as we plan on supporting both platforms ci should also take care of both of them. |
ok, I will create a task to add ci for them |
With this our sdk supports fabric architecture. How to test:
For Android: in the
gradle.propertiesfile there is a variablenewArchEnabled- set it to true to enable fabric architecture for example app (and therefore our sdk) HOWEVER there is a problem on some newer phones that on the second screen you can't click anything and it's probably a bug in react-navigation lib, it's being fixed by the open-source teamFor iOS: in the
example/ios/Podfile.properties.jsonthere is a variablenewArchEnabled, set it to true to enable fabric architecture for example app (and therefore our sdk) HOWEVER there is a bug in expo-font library and similar and all fonts and icons are broaken on fabric, expo team is working on thisAlso remember when switching between architectures to always clean cache etc. you may also need to delete
Podsorbuildfolders or even just clone the repo again :pWhen reviewing focus on the new modules (whether the code style is ok) and whether I've missed something (this repo is recreated from scratch 😅).
Also react-native and other libraries are updated <3
Thoughts: