[MV-364] Fix screencast crashes on Android (#87)

fishjam-dev · Apr 7, 2023 · 00a7c80 · 00a7c80
1 parent def5be6
commit 00a7c80
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -175,6 +175,6 @@ dependencies {
   api 'com.facebook.react:react-native:+'
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
   implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:${versions.coroutines}"
-  implementation 'com.github.jellyfish-dev:membrane-webrtc-android:4.2.1'
+  implementation 'com.github.jellyfish-dev:membrane-webrtc-android:4.3.1'
   implementation 'com.twilio:audioswitch:1.1.7'
 }
diff --git a/android/src/main/java/com/reactnativemembrane/MembraneModule.kt b/android/src/main/java/com/reactnativemembrane/MembraneModule.kt
@@ -462,9 +462,7 @@ class MembraneModule(reactContext: ReactApplicationContext) :
       maxBitrate = screencastMaxBandwidth,
     )
 
-    localScreencastTrack = room?.createScreencastTrack(mediaProjectionPermission, videoParameters, screencastMetadata) {
-      stopScreencast()
-    }
+    localScreencastTrack = room?.createScreencastTrack(mediaProjectionPermission, videoParameters, screencastMetadata)
 
     localScreencastTrack?.let {
       val participant = participants[localParticipantId]
@@ -478,8 +476,8 @@ class MembraneModule(reactContext: ReactApplicationContext) :
     isScreenCastOn = false
 
     localScreencastTrack?.let {
-      room?.removeTrack(it.id())
       participants[localParticipantId]?.removeTrack(it)
+      room?.removeTrack(it.id())
       emitParticipants()
       localScreencastTrack = null
     }