Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

Add handle_child_pad_removed callback #299

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Add handle_child_pad_removed callback #299

merged 2 commits into from
Jul 21, 2023

Conversation

dmorn
Copy link
Contributor

@dmorn dmorn commented Jul 20, 2023

  • Add handle_child_pad_removed callback
  • Add missing callback in WebRTC endpoint

dmorn added 2 commits July 20, 2023 14:46
@dmorn
Add handle_child_pad_removed callback
be5adbf 
In theory this callback is optional. In practice
with membrane_core 0.12 we keep on getting hit
with a callback unimplemented crash.
@dmorn
Add missing callback in WebRTC endpoint
fcf5167
@dmorn dmorn requested a review from mickel8 as a code owner July 20, 2023 15:29
@dmorn
Copy link
Contributor Author

dmorn commented Jul 20, 2023

Fixes #296

@mickel8
Copy link
Contributor

mickel8 commented Jul 21, 2023

Hi @dmorn!

Thanks for the fix!

@mickel8 mickel8 merged commit 917ccca into fishjam-dev:master Jul 21, 2023
@mickel8 mickel8 mentioned this pull request Aug 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mickel8 mickel8 Awaiting requested review from mickel8 mickel8 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmorn @mickel8