Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

[RTC-117] Add padding packets metric #279

Merged
merged 9 commits into from
Jun 21, 2023
Merged

[RTC-117] Add padding packets metric #279

merged 9 commits into from
Jun 21, 2023

Conversation

mickel8
Copy link
Contributor

@mickel8 mickel8 commented Jun 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #279 (648d234) into master (64a7b44) will decrease coverage by 0.09%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   63.05%   62.97%   -0.09%     
==========================================
  Files          44       44              
  Lines        2125     2131       +6     
==========================================
+ Hits         1340     1342       +2     
- Misses        785      789       +4     
Impacted Files Coverage Δ
lib/membrane_rtc_engine/metrics.ex 0.00% <ø> (ø)
...rane_rtc_engine/endpoints/webrtc/track_receiver.ex 49.47% <20.00%> (-1.08%) ⬇️
lib/membrane_rtc_engine/utils.ex 14.28% <50.00%> (+2.16%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a7b44...648d234. Read the comment docs.

@mickel8 mickel8 requested a review from LVala June 19, 2023 14:09
Copy link
Contributor

@LVala LVala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch is out of date and that might be why 5 out of 7 integration tests failed, code itself is 👍

Edit: or the new jammy membrane_docker image? idk

@mickel8
Copy link
Contributor Author

mickel8 commented Jun 20, 2023

Ehhh....

@mickel8 mickel8 merged commit 01ee44c into master Jun 21, 2023
@mickel8 mickel8 deleted the paddings-metric branch June 21, 2023 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants