Add screensharing field to track metadata and handle it in custom lay… #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 60.51% 60.21% -0.30%
==========================================
Files 43 43
Lines 2031 2041 +10
==========================================
Hits 1229 1229
- Misses 802 812 +10
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -469,7 +469,7 @@ defmodule Membrane.RTC.HLSEndpointTest do | |||
| pt: 96 | |||
| }, | |||
| id: video_track_id, | |||
| metadata: %{"mainPresenter" => true} | |||
| metadata: %{"mainPresenter" => true, "isScreenSharing" => false} | |||
There was a problem hiding this comment.
We shouldn't use metadata in such a way. Metadata are meant to contain arbitrary user data and engine is not supposed to look into this data. Maybe a new field like options on the client side, which contains all possible options is the way to go 🤔
We can merge it as it is but that's something we should address ASAP. Please make an issue
| @impl true | ||
| def track_updated(track, stream_format \\ nil, state) |
There was a problem hiding this comment.
This is callback so there is no need to define default values
| @impl true | |
| def track_updated(track, stream_format \\ nil, state) |
No description provided.