This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Fix cropped share screen #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-jodlos
approved these changes
Mar 20, 2023
Rados13
approved these changes
Mar 20, 2023
Comment on lines
14
to
15
| @type track_no :: pos_integer() | ||
| @type padding :: pos_integer() |
There was a problem hiding this comment.
Why pos_integer instead of non_neg_integer, don't you iterate tracks from 0?
Karolk99
force-pushed
the
ML-274-cropped-sharescreen
branch
from
792fc5e to
72bed29
Compare
Rados13
approved these changes
Mar 20, 2023
Comment on lines
+506
to
+509
| # output_manifests = | ||
| # Enum.filter(output_files, fn file -> | ||
| # String.match?(file, ~r/\.m3u8$/) and file != @main_manifest | ||
| # end) |
There was a problem hiding this comment.
If we don't use it shouldn't we remove it, or add some comments that this will be fixed in the future?
Karolk99
force-pushed
the
ML-274-cropped-sharescreen
branch
2 times, most recently
from
462734b to
eee53a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 57.77% 57.73% -0.05%
==========================================
Files 38 40 +2
Lines 1788 1791 +3
==========================================
+ Hits 1033 1034 +1
- Misses 755 757 +2
Continue to review full report in Codecov by Sentry.
|
Karolk99
force-pushed
the
ML-274-cropped-sharescreen
branch
from
eee53a2 to
771b8a8
Compare
Rados13
reviewed
Mar 22, 2023
Comment on lines
+268
to
+269
| assert_receive({:playlist_playable, :audio, ^output_dir}, 50_000) | ||
| assert_receive({:playlist_playable, :video, ^output_dir}, 50_000) |
There was a problem hiding this comment.
that's how much time it takes when circle Ci servers are the slowest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://membraneframework.atlassian.net/browse/ML-274