Fix/new track notification #249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage ? 59.16%
=========================================
Files ? 38
Lines ? 1783
Branches ? 0
=========================================
Hits ? 1055
Misses ? 728
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -398,6 +398,8 @@ defmodule Membrane.RTC.Engine.Endpoint.WebRTC do | |||
|
|
|||
| variant = to_track_variant(rid) | |||
|
|
|||
| Membrane.Logger.info("New incoming WebRTC track #{track_id} with SSRC #{inspect(ssrc)}") | |||
There was a problem hiding this comment.
We have already similar log in the engine module https://github.com/jellyfish-dev/membrane_rtc_engine/blob/1620023e0a1328b98a979690e13059afa8690248/lib/membrane_rtc_engine/engine.ex#L711 so I would put this one on debug
There was a problem hiding this comment.
The main issue with that log is that it is missing the SSRC - without it, it's extremely hard to correlate them. Originally, in a previous PR, I changed the log you mentioned to include the ssrc that I added to :track_ready message, but I realized it is incompatible with other endpoints and breaks the API for them.
I'm open to any other ideas for logging the SSRC <> track_id mapping, but I guess this is the most straightforward solution
In e2a841a I've removed too much, this PR fixes that and makes integration tests pass (at least locally)