Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

Get endpoints #224

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Get endpoints #224

merged 6 commits into from
Feb 23, 2023

Conversation

Rados13
Copy link
Contributor

@Rados13 Rados13 commented Jan 20, 2023

No description provided.

@Rados13 Rados13 requested a review from mickel8 as a code owner January 20, 2023 09:04
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #224 (85e947b) into master (b99d493) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   59.15%   59.10%   -0.06%     
==========================================
  Files          38       38              
  Lines        1775     1780       +5     
==========================================
+ Hits         1050     1052       +2     
- Misses        725      728       +3     
Impacted Files Coverage Δ
lib/membrane_rtc_engine/engine.ex 74.28% <100.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99d493...85e947b. Read the comment docs.

@Rados13 Rados13 self-assigned this Jan 23, 2023
Copy link
Contributor

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for core 0.11 and implement this using Pipeline.call

@LVala
Copy link
Contributor

LVala commented Feb 20, 2023

Dialyzer fails because of invalid typespec of Membrane.Pipeline.call/3. Not anymore.

@LVala LVala requested a review from mickel8 February 20, 2023 15:07
@mickel8 mickel8 merged commit 3cd88fa into master Feb 23, 2023
@mickel8 mickel8 deleted the get_endpoints branch February 23, 2023 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants