This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Fix RC when subscribing to a track #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-jodlos
approved these changes
May 20, 2022
Co-authored-by: Daniel Jodłoś <daniel.jodlos@swmansion.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscribing to a track we might fail because track we are trying to subscribe to has been deleted just before doing the subscription and we haven't received this information yet. This PR fixes that RC by ignoring
{:error, :invalid_track_id}returned fromEngine.subscribe.The other solution would be to distinct between
:invalid_track_idand:track_already_removederrors. To achieve this we had to introduce buffer for already removed tracks with some arbitrary capacity.