This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Move TS code to a separate repository #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
separate-ts-client
branch
3 times, most recently
from
e5d1794 to
c60ad16
Compare
mickel8
force-pushed
the
separate-ts-client
branch
from
c60ad16 to
ed67a27
Compare
mat-hek
approved these changes
May 4, 2022
README.md
Outdated
| ## Copyright and License | ||
|
|
||
| Copyright 2021, [Software Mansion](https://swmansion.com/?utm_source=git&utm_medium=readme&utm_campaign=membrane_rtc_engine) | ||
| Copyright 2022, [Software Mansion](https://swmansion.com/?utm_source=git&utm_medium=readme&utm_campaign=membrane_rtc_engine) |
| Thanks to this, there is no need to include compiled JS code in `priv/static`. It will be generated each time `mix compile` is called. | ||
|
|
||
| TypeScript documentation will be generated under `doc/js/`. | ||
| To make the development a little easier, we have added `mix integration_test` task, which runs integration tests from `integration/test_videoroom`. |
There was a problem hiding this comment.
I guess integration tests should be run by default when doing mix test
There was a problem hiding this comment.
They take too much time at the moment. I think that several minutes (about ~2/3)
mickel8
force-pushed
the
separate-ts-client
branch
from
1cb3a59 to
d5119f3
Compare
mickel8
added a commit
that referenced
this pull request
May 16, 2022
mickel8
added a commit
that referenced
this pull request
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now, JS/TS client SDK can be found under https://github.com/membraneframework/membrane-webrtc-js