Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

Remove libnice by updating membrane_webrtc_plugin #113

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Remove libnice by updating membrane_webrtc_plugin #113

merged 1 commit into from
Apr 27, 2022

Conversation

mickel8
Copy link
Contributor

@mickel8 mickel8 commented Apr 22, 2022

No description provided.

@mickel8 mickel8 force-pushed the update-deps branch 11 times, most recently from d083caa to a6a41c0 Compare April 23, 2022 14:01
@mickel8 mickel8 changed the title Update membrane_webrtc_plugin and telemetry Remove libnice by updating membrane_webrtc_plugin Apr 23, 2022
@mickel8 mickel8 force-pushed the update-deps branch 8 times, most recently from cb85a26 to 5a1159d Compare April 23, 2022 15:50
@mickel8 mickel8 mentioned this pull request Apr 23, 2022
Closed
@mickel8 mickel8 requested a review from Rados13 April 25, 2022 11:49
@mickel8 mickel8 self-assigned this Apr 25, 2022
Rados13
Rados13 reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@Rados13 Rados13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we use our implementation of ice-lite instead of libnice? This way we wouldn't relay only on our integrated turn servers.

Rados13
Rados13 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@Rados13 Rados13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add issues for:

  • adding the possibility of using ice-lite without integrated turns
  • adding integration tests for TLS integrated tests

@mickel8 mickel8 merged commit 0feee1e into master Apr 27, 2022
@mickel8 mickel8 deleted the update-deps branch April 27, 2022 08:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rados13 Rados13 Rados13 approved these changes

Assignees

@mickel8 mickel8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickel8 @Rados13