This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Fix RC in removing peers/endpoints #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a RC while removing peers/endpoints because we were assuming that returning action
remove_childfrom Membrane callback will immidiately remove given child from Membrane context.That's not true and can result in desynchronization between our internal state and Membrane ctx i.e. some child can be present in Membrane context but it might be absent in our internal state.
Current solution can be changed once Membrane starts informing about successful peer/endpoint removal.