This repository has been archived by the owner on May 13, 2024. It is now read-only.
Karkakol/add simulcast config to endpoints #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump release-it * Add allow-warnings to pod trunk
karkakol
requested review from
graszka22 and
incubo4u
and removed request for
graszka22
graszka22
reviewed
Jan 16, 2024
.idea/membrane-webrtc-ios.iml
Outdated
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module type="WEB_MODULE" version="4"> | ||
| <component name="NewModuleRootManager"> | ||
| <content url="file://$MODULE_DIR$"> |
There was a problem hiding this comment.
don't we need to gitignore this stuff too?
| @@ -30,12 +30,12 @@ public protocol ReceivableEvent { | |||
| var type: ReceivableEventType { get } | |||
| } | |||
|
|
|||
| internal struct ReceivableEventBase: Decodable { | |||
| public struct ReceivableEventBase: Decodable { | |||
There was a problem hiding this comment.
why public? it was intentionally internal in order to not expose this to the user and to generate docs nicely
this also applies to the other places
graszka22
reviewed
Jan 16, 2024
| @@ -3,49 +3,59 @@ public struct Endpoint: Codable { | |||
| public let type: String | |||
| public let metadata: Metadata | |||
| public let trackIdToMetadata: [String: Metadata]? | |||
| public let tracks: [String: TracksAddedEvent.Data.TrackData]? | |||
There was a problem hiding this comment.
wouldn't it be easier if we had no ? here? it can be always an empty array if there are no tracks?
There was a problem hiding this comment.
i will ask if tracks can be null to JF backend devs
graszka22
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.