This repository has been archived by the owner on May 13, 2024. It is now read-only.
[MV-410] Add getStats function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graszka22
reviewed
Apr 27, 2023
| let tmp = RTCOutboundStats( | ||
| kind: it.values["kind"] as? String ?? "", | ||
| rid: it.values["rid"] as? String ?? "", | ||
| bytesSent: it.values["bytesSent"] as? Int ?? 0, |
There was a problem hiding this comment.
it's int? not any big number? or NSDecimalNumber?
There was a problem hiding this comment.
Int on a modern IPhone has 63 bit precision, which should be more than enough since when changed from bytes it would mean that the peer must have had used several petabytes to exceed that, and backed would prob crash first :P. I changed it to be UInt to get that additional bit of precision, but I think it is irrelevant.
| } | ||
|
|
||
| public func getStats() -> [String: RTCStats] { | ||
| if connection != nil { |
There was a problem hiding this comment.
Suggested change
| if connection != nil { | |
| if let connection = connection { |
graszka22
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mimics fishjam-dev/membrane-webrtc-android@1f88e81 but for IOS sdk