Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce room_id generator #206

Merged
merged 6 commits into from
May 31, 2024
Merged

feat: introduce room_id generator #206

merged 6 commits into from
May 31, 2024

Conversation

kamciokodzi
Copy link
Contributor

@kamciokodzi kamciokodzi commented May 28, 2024

This PR introduces:

  • Room ID generator based on the node name where the room was created
  • Determining which node owns given room
  • Replaced rpc with erpc
  • Introduce primitive feature flag module

Docs

Acknowledging the stipulations set forth:

  • I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 86.89%. Comparing base (0b3270f) to head (25da293).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   87.12%   86.89%   -0.24%     
==========================================
  Files          74       77       +3     
  Lines        1538     1549      +11     
==========================================
+ Hits         1340     1346       +6     
- Misses        198      203       +5     
Files Coverage Δ
lib/fishjam/application.ex 48.64% <ø> (ø)
lib/fishjam/component/file.ex 100.00% <ø> (ø)
lib/fishjam/component/hls/recording.ex 89.47% <100.00%> (ø)
lib/fishjam/component/hls/request_handler.ex 91.89% <100.00%> (ø)
lib/fishjam/feature_flags.ex 100.00% <100.00%> (ø)
lib/fishjam/room/config.ex 100.00% <100.00%> (+3.57%) ⬆️
lib/fishjam/room/id.ex 91.66% <91.66%> (ø)
lib/fishjam/room_service.ex 85.50% <40.00%> (-1.51%) ⬇️
lib/fishjam/rpc_client.ex 44.44% <44.44%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3270f...25da293. Read the comment docs.

lib/fishjam/room/config.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Show resolved Hide resolved
lib/fishjam/rpc_client.ex Outdated Show resolved Hide resolved
lib/fishjam/rpc_client.ex Outdated Show resolved Hide resolved
lib/fishjam/feature_flags.ex Show resolved Hide resolved
lib/fishjam/feature_flags.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Show resolved Hide resolved
lib/fishjam/room/id.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Outdated Show resolved Hide resolved
lib/fishjam/room/id.ex Outdated Show resolved Hide resolved
lib/fishjam/rpc_client.ex Outdated Show resolved Hide resolved
@kamciokodzi kamciokodzi merged commit 07a89a9 into main May 31, 2024
7 checks passed
@kamciokodzi kamciokodzi deleted the feat/rpc-client branch May 31, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants