Add logs about errors during adding peer #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 86.89% 87.19% +0.30%
==========================================
Files 77 77
Lines 1549 1570 +21
==========================================
+ Hits 1346 1369 +23
+ Misses 203 201 -2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Do we want to merge this PR? |
sgfn
reviewed
May 28, 2024
sgfn
approved these changes
May 28, 2024
| @@ -107,6 +107,10 @@ defmodule FishjamWeb.RoomController do | |||
| room_id = Map.get(params, "roomId") | |||
| {:error, :bad_request, "Cannot add room with id \"#{room_id}\" - room already exists"} | |||
|
|
|||
| {:error, :room_doesnt_start} -> | |||
| room_id = Map.get(params, "roomId") | |||
| {:error, :bad_request, "Cannot add room with id \"#{room_id}\" - adding failed"} | |||
There was a problem hiding this comment.
How about "unexpected error" instead? I feel like we're repeating ourselves with "adding failed"
mickel8
reviewed
May 28, 2024
mickel8
approved these changes
May 29, 2024
| @@ -65,6 +66,8 @@ defmodule FishjamWeb.PeerController do | |||
| ] | |||
|
|
|||
| def create(conn, %{"room_id" => room_id} = params) do | |||
| Logger.debug("Successfully added peer to room: #{room_id}") | |||
There was a problem hiding this comment.
Let's move this inside with
Co-authored-by: Michał Śledź <michalsledz34@gmail.com>
Co-authored-by: Michał Śledź <michalsledz34@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acknowledging the stipulations set forth: