Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lelantus unittests and fixes #950

Merged
merged 13 commits into from
Dec 24, 2020
Merged

Lelantus unittests and fixes #950

merged 13 commits into from
Dec 24, 2020

Conversation

levonpetrosyan93
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 commented Dec 21, 2020 •
edited
Loading

What brings this PR

  1. Fixing and adding unit tests
  2. Fixing bug at coin choosing algorithm
  3. Fixing bug resulting wrong debug log at joinsplit creation
  4. Fixing minor bug at joinsplit creation (our implementation was not resulting it, but in unit tests we have such case)
  5. Fixing crashes when upgrading with non-hd wallet
  6. Fixing issues and crashes when -disablewallet arg used, Segmentation fault in GUI of v0.14.1.2 in Ubuntu 18.04 #939
  7. Removed wrong background color when dark mode is used.
  8. Fixes Daemon and QT crashes #946, the reason was incorrect mutex locks.
  9. Fixed crash after try to create lelantus mint when wallet not yet synced, Prevented 0 mint creation at Ui level.

@lgtm-com
Copy link

lgtm-com bot commented Dec 21, 2020

This pull request introduces 11 alerts when merging 7f61976 into 2508162 - view on LGTM.com

new alerts:

  • 6 for Overwriting attribute in super-class or sub-class
  • 5 for 'import *' may pollute namespace

psolstice
psolstice reviewed Dec 23, 2020
View reviewed changes
qa/rpc-tests/lelantus_mintspend.py Outdated
mint_trans.append(self.nodes[0].mintlelantus(2))

# Get last added transaction and fee for it
info = self.nodes[0].gettransaction(mint_trans[-1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails here

psolstice
psolstice requested changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@psolstice psolstice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix failing test

@lgtm-com
Copy link

lgtm-com bot commented Dec 24, 2020

This pull request introduces 11 alerts when merging 3a79943 into 2508162 - view on LGTM.com

new alerts:

  • 6 for Overwriting attribute in super-class or sub-class
  • 5 for 'import *' may pollute namespace

@reubenyap reubenyap merged commit edee678 into master Dec 24, 2020
@reubenyap reubenyap deleted the lelantus_unittests branch December 24, 2020 07:12
@justanwar justanwar mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psolstice psolstice psolstice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daemon and QT crashes
3 participants
@levonpetrosyan93 @psolstice @reubenyap