Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev build #880

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix dev build #880

merged 1 commit into from
Jul 15, 2020

Conversation

riordant
Copy link
Contributor

@riordant riordant commented Jul 14, 2020 •
edited
Loading

PR intention

Development build failing following #857. the Makefile includes stacktraces.cpp/h in all builds, which has a dependancy coming from depends/ (backtrace.h).

Code changes brief

  • Only include stacktrace.cpp/h if --enable-crash-hooks flag is used (only enabled for depends/ build).
  • Add guards around functions from stacktrace.cpp

@lgtm-com
Copy link

lgtm-com bot commented Jul 14, 2020

This pull request fixes 4 alerts when merging 333a337 into 42e79ff - view on LGTM.com

fixed alerts:

  • 2 for Missing return statement
  • 2 for Unused static function

@riordant riordant merged commit c5bfd41 into master Jul 15, 2020
@riordant riordant deleted the dev-build-fix branch July 15, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psolstice psolstice psolstice approved these changes

@a-bezrukov a-bezrukov a-bezrukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riordant @psolstice @a-bezrukov