Removed block syncing in elysium reindex test #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riordant
approved these changes
Jun 30, 2020
|
What is the difference between the old method and the new method? |
|
@ultimaweapon I added the delay in the first place because I found new blocks are generated while the reindex flag is set which should be the reason why new blocks are not broadcasted and make syncing block logic fail. But as I said in the PR description this test focus on the local state then I remove syncing logic out in this PR. |
a-bezrukov
approved these changes
Jul 1, 2020
riordant
pushed a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Fix test fails while trying to sync block by removing syncing logic because this test focuses on node state validation after reindexing.
Code changes brief