Fix for assert during certain cases of invalidateblock #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
approved these changes
Jul 1, 2020
a-bezrukov
approved these changes
Jul 1, 2020
riordant
pushed a commit
that referenced
this pull request
Jul 13, 2020
* Fix for assert during certain cases of invalidateblock * A race condition in block download is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Sigma code bug might cause assert on block disconnect. This PR prevents this
Code changes brief
sigmaMintedPubCoinsfield ofCBlockIndexis accessed for read throughoperator []without checking if the specific entry being queried already exists. It is possible to code inCSigmaState::RemoveBlock()to incorrectly process this empty entry and fail with assert.This PR ensures that zero sized entry of
sigmaMintedPubCoinsis handled correctly and prevents unnecessary creation of new entities of this type