Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction large error message change #1438

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

levoncrypto
Copy link
Contributor

No description provided.

Copy link

coderabbitai bot commented May 7, 2024

Walkthrough

The recent updates across various components of the firo-core software involve refining error messages for transactions that exceed the size limit. The new messages provide clearer guidance on how to reduce transaction sizes, specifically suggesting the consolidation of UTXOs or selecting fewer inputs to stay within the 100 kB limit.

Changes

File Path Change Summary
.../bitcoinstrings.cpp Updated the "Transaction too large" error message to include specific guidance on staying under the 100 kB limit.
.../spark/sparkwallet.cpp
.../wallet/lelantusjoinsplitbuilder.cpp
.../wallet/txbuilder.cpp
.../wallet/wallet.cpp
In various wallet-related files, error messages for large transactions were enhanced to advise on reducing transaction size and detail the 100 kB limit.

🐇✨
In the land of code, where the bits roam free,
A tiny rabbit hopped, changing messages with glee.
"Too large, too large!" the old warnings cried,
Now "Less inputs, please," they guide.
With a hop and a skip, transactions now fit,
Thanks to the rabbit's clever wit.
🌟🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Out of diff range and nitpick comments (1)
src/qt/bitcoinstrings.cpp (1)

556-556: Update error message to enhance user guidance.

Consider changing "please select less inputs" to "please select fewer inputs" for grammatical correctness.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7fb07bf and 8d624d3.
Files selected for processing (5)
  • src/qt/bitcoinstrings.cpp (1 hunks)
  • src/spark/sparkwallet.cpp (2 hunks)
  • src/wallet/lelantusjoinsplitbuilder.cpp (1 hunks)
  • src/wallet/txbuilder.cpp (1 hunks)
  • src/wallet/wallet.cpp (3 hunks)
Files skipped from review due to trivial changes (1)
  • src/wallet/wallet.cpp
Additional comments not posted (2)
src/wallet/txbuilder.cpp (1)

227-227: Updated error message provides clearer instructions for users on how to handle transactions exceeding the size limit.

src/wallet/lelantusjoinsplitbuilder.cpp (1)

324-324: Updated error message provides clearer instructions for users on how to handle transactions exceeding the size limit.

@@ -1024,7 +1024,7 @@ bool CSparkWallet::CreateSparkMintTransactions(
// Limit size
CTransaction txConst(tx);
if (GetTransactionWeight(txConst) >= MAX_STANDARD_TX_WEIGHT) {
strFailReason = _("Transaction too large");
strFailReason = _("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure error message consistency and clarity.

- strFailReason = _("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again");
+ strFailReason = _("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again.");

The error message should maintain grammatical consistency ("fewer" instead of "less" for countable items like inputs) and clarity (adding a period before the suggestion). This change aligns with the updated messages in other parts of the codebase.


Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
strFailReason = _("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again");
strFailReason = _("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again.");

@@ -1536,7 +1536,7 @@ CWalletTx CSparkWallet::CreateSparkSpendTransaction(
}

if (GetTransactionWeight(tx) >= MAX_NEW_TX_WEIGHT) {
throw std::runtime_error(_("Transaction too large"));
throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure error message consistency and clarity.

- throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"));
+ throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again."));

Similar to the previous comment, this error message should also be updated for grammatical accuracy and consistency with other updated messages in the codebase.


Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"));
throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again."));

@@ -553,7 +553,7 @@ QT_TRANSLATE_NOOP("firo-core", "Transaction has too long of a mempool chain"),
QT_TRANSLATE_NOOP("firo-core", "Transaction must have at least one recipient"),
QT_TRANSLATE_NOOP("firo-core", "Transaction not valid."),
QT_TRANSLATE_NOOP("firo-core", "Transaction too large for fee policy"),
QT_TRANSLATE_NOOP("firo-core", "Transaction too large"),
QT_TRANSLATE_NOOP("firo-core", "This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest something like

Suggested change
QT_TRANSLATE_NOOP("firo-core", "This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"),
QT_TRANSLATE_NOOP("firo-core", "transaction is too large (size limit: 100Kb). Select less inputs or consolidate your UTXOs"),

to make things clearer for non-technical users

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8d624d3 and 5748ccb.
Files selected for processing (5)
  • src/qt/bitcoinstrings.cpp (1 hunks)
  • src/spark/sparkwallet.cpp (2 hunks)
  • src/wallet/lelantusjoinsplitbuilder.cpp (1 hunks)
  • src/wallet/txbuilder.cpp (1 hunks)
  • src/wallet/wallet.cpp (3 hunks)
Files skipped from review as they are similar to previous changes (5)
  • src/qt/bitcoinstrings.cpp
  • src/spark/sparkwallet.cpp
  • src/wallet/lelantusjoinsplitbuilder.cpp
  • src/wallet/txbuilder.cpp
  • src/wallet/wallet.cpp

@reubenyap reubenyap merged commit cf19353 into master May 13, 2024
6 checks passed
@reubenyap reubenyap deleted the Change_Txlarge_message branch May 13, 2024 14:55
firstcryptoman pushed a commit that referenced this pull request May 15, 2024
* Transaction large error message change

* Еditing error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants