update from ethereum #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events with just 1 argument fail before this change
rpc: enforce the 128KB request limits on websockets too
containers: drop vagrant support, noone's maintaining it
accounts/abi, core: add AddTxWithChain in BlockGen for simulation
* crypto/bn256: full switchover to cloudflare's code * crypto/bn256: only use cloudflare for optimized architectures * crypto/bn256: upstream fallback for non-optimized code * .travis, build: drop support for Go 1.8 (need type aliases) * crypto/bn256/cloudflare: enable curve mul lattice optimization
* build: add GOBIN to PATH for gomobile * build: install gobind alongside gomobile
Fix issue unmarshaling single parameter events from abigen generated go code #16208
core: minor evm polishes and optimizations
The parameter `rand` is unused in `PrivateKey.Decrypt`. Decryption in the ECIES encryption scheme is deterministic, so randomness isn't needed.
cmd: implement preimage dump and import cmds
* cmd/puppeth: add constraints to network name * cmd/puppeth: update usage of network arg * cmd/puppeth: avoid package dependency on utils
core/vm: Fixed typos
* rpc/*: golint error with context as last parameter * Update json.go
* metrics/*: golint updates for this or self warning * metrics/*: golint updates for this or self warning, updated pr from feedback
* event/*: golint updates for this or self warning * event/*: golint updates for this or self warning, pr updated per feedback
* eth/*:golint updates for this or self warning * eth/*: golint updates for this or self warning, pr updated per feedback
* signer/*: golint fixes Specifically naming and comment formatting for documentation * signer/*: fixed naming error crashing build * signer/*: corrected error * signer/core: fix tiny error whitespace * signer/rules: fix test refactor
* whisper/mailserver: pass init error to the caller * whisper/mailserver: add returns to fmt.Errorf * whisper/mailserver: check err in mailserver init test
Peer.run was discarding the reason for disconnection sent to the disc channel by Disconnect.
* cmd: various golint fixes * cmd: update to pr change request * cmd: update to pr change request
* eth/filter: check nil pointer when unsubscribe * eth/filters, accounts, rpc: abort system if subscribe failed * eth/filter: add crit log before exit * eth/filter, event: minor fixes
* all: get rid of error when create mdb * core: clean up variables definition * all: inline mdb definition
Feed keeps active subscription channels in a slice called 'f.sendCases'. The Send method tracks the active cases in a local variable 'cases' whose value is f.sendCases initially. 'cases' shrinks to a shorter prefix of f.sendCases every time a send succeeds, moving the successful case out of range of the active case list. This can be confusing because the two slices share a backing array. Add more comments to document what is going on. Also add a test for removing a case that is in 'f.sentCases' but not 'cases'.
* bmt/*: golint updates for this or self warning * Update bmt.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.