FDS Source: Add IMPICIT NONE (TYPE,EXTERNAL)

Build/makefile

@@ -173,7 +173,7 @@ impi_intel_win_64_dv : setup_win $(objwin_mpi)
 
 impi_intel_win_64_db : MPILIB = "$(IMPI_DEBUG_ROOT)\impi.lib"
 impi_intel_win_64_db : MPIINCLUDE = "$(IMPI_INCLUDE)"
-impi_intel_win_64_db : FFLAGS = /Od /nologo /debug:all /I$(MPIINCLUDE) /Z7 /extend-source:132 /warn:unused /warn:nointerfaces /Qtrapuv /fp:strict /fp:except /traceback /check:all /stand:f08 /wrap-margin- $(GITINFO) $(INTELMPI_COMPINFO) $(FFLAGSMKL_INTEL)
+impi_intel_win_64_db : FFLAGS = /Od /nologo /debug:all /I$(MPIINCLUDE) /Z7 /extend-source:132 /warn:unused /warn:nointerfaces /Qtrapuv /fp:strict /fp:except /traceback /check:all /stand:f18 /wrap-margin- $(GITINFO) $(INTELMPI_COMPINFO) $(FFLAGSMKL_INTEL)
 impi_intel_win_64_db : FOPENMPFLAGS = /Qopenmp
 impi_intel_win_64_db : FCOMPL = ifort
 impi_intel_win_64_db : obj = fds_impi_win_64_db
@@ -191,11 +191,6 @@ impi_intel_linux_64 : setup $(obj_mpi)
 	$(FCOMPL) $(FFLAGS) $(LFLAGS) $(FOPENMPFLAGS) -o $(obj) $(obj_mpi) $(LFLAGSMKL)
 
 impi_intel_linux_64_db : FFLAGS = -m64 -check all -warn all -O0 -g -traceback -fpe0 -fltconsistency -stand:f18 -no-wrap-margin $(GITINFO) $(INTELMPI_COMPINFO) $(FFLAGSMKL_INTEL)
-ifneq ($(shell echo "check_quotes"),"check_quotes")
-ifeq ($(shell expr $(INTELMAJOR_COMPVERSION) \> 19), 1)
-impi_intel_linux_64_db : FFLAGS += -warn noexternals
-endif
-endif
 impi_intel_linux_64_db : LFLAGSMKL = $(LFLAGSMKL_INTEL)
 impi_intel_linux_64_db : LFLAGS =
 impi_intel_linux_64_db : FCOMPL = mpiifort

Source/ccib.f90

@@ -14,7 +14,7 @@ MODULE CC_SCALARS_IBM
 USE COMP_FUNCTIONS, ONLY: CURRENT_TIME, GET_FILE_NUMBER
 USE MATH_FUNCTIONS, ONLY: SCALAR_FACE_VALUE
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 LOGICAL, PARAMETER :: NEW_SCALAR_TRANSPORT = .TRUE.
 

Source/cons.f90

@@ -8,7 +8,7 @@ MODULE GLOBAL_CONSTANTS
 USE PRECISION_PARAMETERS
 USE MPI_F08
 USE ISO_FORTRAN_ENV, ONLY: ERROR_UNIT
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 INTEGER, PARAMETER :: DNS_MODE=1                 !< Flag for SIM_MODE: Direct Numerical Simulation
 INTEGER, PARAMETER :: LES_MODE=2                 !< Flag for SIM_MODE: Large Eddy Simulation
@@ -729,7 +729,7 @@ END MODULE GLOBAL_CONSTANTS
 MODULE RADCONS
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 REAL(EB), ALLOCATABLE, DIMENSION(:,:) :: DLN                !< Wall-normal matrix
 REAL(EB), ALLOCATABLE, DIMENSION(:,:) :: ORIENTATION_FACTOR !< Fraction of radiation angle corresponding to a particular direction

Source/ctrl.f90

@@ -7,7 +7,7 @@ MODULE CONTROL_FUNCTIONS
 USE GLOBAL_CONSTANTS, ONLY : DO_EVACUATION,EVACUATION_ONLY,UPDATE_DEVICES_AGAIN
 USE DEVICE_VARIABLES
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 

Source/data.f90

@@ -4,7 +4,7 @@ MODULE OUTPUT_DATA
 
 USE PRECISION_PARAMETERS
 USE GLOBAL_CONSTANTS, ONLY: CELL_CENTER
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 INTEGER, PARAMETER :: N_Q_DOT=8,N_M_DOT=4
 INTEGER :: PLOT3D_QUANTITY_INDEX(5),PLOT3D_Y_INDEX(5)=0,PLOT3D_Z_INDEX(5)=0,PLOT3D_PART_INDEX(5),&
@@ -2222,7 +2222,7 @@ END MODULE OUTPUT_DATA
 
 MODULE PROPERTY_DATA
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 TYPE ELEMENT_TYPE
    CHARACTER(3):: ABBREVIATION

Source/devc.f90

@@ -3,7 +3,7 @@
 MODULE DEVICE_VARIABLES
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 INTEGER, ALLOCATABLE, DIMENSION(:) :: DEVC_PIPE_OPERATING
 
@@ -129,7 +129,7 @@ MODULE CONTROL_VARIABLES
 
 USE PRECISION_PARAMETERS
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 !> !\{
 !> Parameter defining the type of control function for CONTROL\%CONTROL_INDEX

Source/divg.f90

@@ -4,7 +4,7 @@ MODULE DIVG
 USE GLOBAL_CONSTANTS
 USE MESH_POINTERS
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PRIVATE
 
 PUBLIC DIVERGENCE_PART_1,DIVERGENCE_PART_2,CHECK_DIVERGENCE

Source/dump.f90

@@ -16,7 +16,7 @@ MODULE DUMP
 USE COMPLEX_GEOMETRY, ONLY : WRITE_GEOM,WRITE_GEOM_ALL,IBM_FGSC,IBM_IDCF,IBM_IDCC,IBM_FTYPE_RGGAS,IBM_FTYPE_CFGAS,IBM_FTYPE_CFINB,&
                              IBM_SOLID,FCELL,IBM_CGSC,IBM_CUTCFE,TRIANGULATE,IBM_VGSC,IBM_GASPHASE
 USE CC_SCALARS_IBM, ONLY : ADD_Q_DOT_CUTCELLS,GET_PRES_CFACE,GET_PRES_CFACE_TEST,GET_UVWGAS_CFACE,GET_MUDNS_CFACE
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PRIVATE
 
 REAL(EB), POINTER, DIMENSION(:,:,:) :: WFX=>NULL(),WFY=>NULL(),WFZ=>NULL()

Source/evac.f90

@@ -67,7 +67,7 @@ MODULE EVAC
   USE DEVICE_VARIABLES
   USE CONTROL_VARIABLES
 
-  IMPLICIT NONE
+  IMPLICIT NONE (TYPE,EXTERNAL)
   PRIVATE
 
   ! Public subprograms (called from the main program or read or dump)

Source/fire.f90

@@ -8,7 +8,7 @@ MODULE FIRE
 USE COMP_FUNCTIONS, ONLY: CURRENT_TIME
 USE SOOT_ROUTINES, ONLY: SOOT_SURFACE_OXIDATION
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 PRIVATE
 

Source/func.f90

@@ -13,7 +13,7 @@
 MODULE COMP_FUNCTIONS
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 
@@ -440,7 +440,7 @@ MODULE MEMORY_FUNCTIONS
 USE PRECISION_PARAMETERS
 USE MESH_VARIABLES
 USE COMP_FUNCTIONS, ONLY : SHUTDOWN
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 
@@ -1360,7 +1360,7 @@ MODULE GEOMETRY_FUNCTIONS
 USE PRECISION_PARAMETERS
 USE MESH_VARIABLES
 USE GLOBAL_CONSTANTS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 
@@ -2308,7 +2308,7 @@ END MODULE GEOMETRY_FUNCTIONS
 MODULE MATH_FUNCTIONS
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 
@@ -3041,7 +3041,7 @@ MODULE PHYSICAL_FUNCTIONS
 USE PRECISION_PARAMETERS
 USE GLOBAL_CONSTANTS
 USE MESH_VARIABLES
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 
@@ -4264,7 +4264,7 @@ END MODULE PHYSICAL_FUNCTIONS
 MODULE TRAN
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 TYPE TRAN_TYPE
    REAL(EB), POINTER, DIMENSION(:,:) :: C1=>NULL(),C2=>NULL(),C3=>NULL(),CCSTORE=>NULL(),PCSTORE=>NULL()
    INTEGER, POINTER, DIMENSION(:,:) :: IDERIVSTORE=>NULL()
@@ -4429,7 +4429,7 @@ MODULE OPENMP
 
 USE GLOBAL_CONSTANTS, ONLY : OPENMP_AVAILABLE_THREADS, OPENMP_USED_THREADS, OPENMP_USER_SET_THREADS, USE_OPENMP
 !$ USE OMP_LIB
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PUBLIC OPENMP_INIT, OPENMP_SET_THREADS, OPENMP_PRINT_STATUS
 
 CONTAINS
@@ -4498,7 +4498,7 @@ END MODULE OPENMP
 MODULE MISC_FUNCTIONS
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 CONTAINS
 

Source/geom.f90

@@ -211,7 +211,7 @@ MODULE COMPLEX_GEOMETRY
  USE MKL_CLUSTER_SPARSE_SOLVER
 #endif /* WITH_MKL */
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 CHARACTER(2*MESSAGE_LENGTH) :: MESSAGE
 
 !! ---------------------------------------------------------------------------------

Source/gsmv.f90

@@ -4,7 +4,7 @@
 MODULE BOXTETRA_ROUTINES
 USE PRECISION_PARAMETERS
 USE MATH_FUNCTIONS, ONLY: CROSS_PRODUCT
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 PRIVATE
 

Source/hvac.f90

@@ -14,7 +14,7 @@ MODULE HVAC_ROUTINES
 USE COMP_FUNCTIONS, ONLY: CURRENT_TIME, CHECKREAD, SHUTDOWN
 USE MEMORY_FUNCTIONS, ONLY: ChkMemErr
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 PRIVATE
 

Source/init.f90

@@ -11,7 +11,7 @@ MODULE INIT
 USE MEMORY_FUNCTIONS, ONLY : CHKMEMERR
 USE DEVICE_VARIABLES
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 PRIVATE
 

Source/main.f90

@@ -45,7 +45,7 @@ PROGRAM FDS
 USE GLOBMAT_SOLVER, ONLY : GLMAT_SOLVER_SETUP_H, GLMAT_SOLVER_H, COPY_H_OMESH_TO_MESH, &
                            FINISH_GLMAT_SOLVER_H,PRESSURE_SOLVER_CHECK_RESIDUALS_U
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 ! Miscellaneous declarations
 

Source/mass.f90

@@ -6,7 +6,7 @@ MODULE MASS
 USE GLOBAL_CONSTANTS
 USE MESH_POINTERS
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PRIVATE
 
 REAL(EB), POINTER, DIMENSION(:,:,:) :: UU,VV,WW,RHOP

Source/mesh.f90

@@ -4,7 +4,7 @@ MODULE MESH_VARIABLES
 
 USE PRECISION_PARAMETERS
 USE TYPES
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 !> \brief Derived type containing the bulk of the variables defined on each mesh.
 !>
@@ -340,7 +340,7 @@ MODULE MESH_POINTERS
 
 USE PRECISION_PARAMETERS
 USE MESH_VARIABLES
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 REAL(EB), POINTER, DIMENSION(:,:,:) :: &
    U,V,W,US,VS,WS,DDDT,D,DS,H,HS,H_PRIME,KRES,FVX,FVY,FVZ,FVX_B,FVY_B,FVZ_B,RHO,RHOS, &

Source/part.f90

@@ -9,7 +9,7 @@ MODULE PART
 USE MEMORY_FUNCTIONS, ONLY: ALLOCATE_STORAGE
 USE COMP_FUNCTIONS, ONLY : CURRENT_TIME
 USE SOOT_ROUTINES, ONLY: DROPLET_SCRUBBING
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 PRIVATE
 

Source/pois.f90

@@ -6,7 +6,7 @@ MODULE POIS
 ! POISSON SOLVER ROUTINES
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PRIVATE
 REAL(EB) SCALE
 INTEGER :: KAPPA,NMAX,IKPWR

Source/prec.f90

@@ -2,7 +2,7 @@
 
 MODULE PRECISION_PARAMETERS
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 INTEGER, PARAMETER :: FB = SELECTED_REAL_KIND(6)     !< Precision of "Four Byte" reals
 INTEGER, PARAMETER :: EB = SELECTED_REAL_KIND(12)    !< Precision of "Eight Byte" reals

Source/pres.f90

@@ -5,7 +5,7 @@ MODULE PRES
 USE PRECISION_PARAMETERS
 USE MESH_POINTERS
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PRIVATE
 
 PUBLIC PRESSURE_SOLVER_COMPUTE_RHS,PRESSURE_SOLVER_FFT,PRESSURE_SOLVER_CHECK_RESIDUALS,COMPUTE_VELOCITY_ERROR
@@ -971,7 +971,7 @@ MODULE GLOBMAT_SOLVER
 USE MKL_CLUSTER_SPARSE_SOLVER
 #endif /* WITH_MKL */
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 
 ! These definitions are the same as geom.f90:
 INTEGER,  PARAMETER :: NGUARD= 2 ! Two layers of guard-cells.

Source/radi.f90

@@ -1,7 +1,7 @@
 MODULE SPECDATA
 
 USE PRECISION_PARAMETERS
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 INTEGER ::  I,J
 INTEGER, PARAMETER :: NWATERK=183
 REAL(EB) :: CPLXREF_WATER(NWATERK,2)
@@ -327,7 +327,7 @@ MODULE MIEV
 USE MEMORY_FUNCTIONS, ONLY : CHKMEMERR
 USE MATH_FUNCTIONS, ONLY : INTERPOLATE1D
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 REAL(EB), ALLOCATABLE :: RDMIE(:),  LMBDMIE(:),LMBDWGHT(:),REAL_REF_INDX(:),CMPLX_REF_INDX(:)
 REAL(EB), ALLOCATABLE :: QSCA(:,:), QABS(:,:),  CHI_F(:,:)
 
@@ -2750,7 +2750,7 @@ MODULE RAD
 USE MESH_VARIABLES
 USE RADCONS
 
-IMPLICIT NONE
+IMPLICIT NONE (TYPE,EXTERNAL)
 PRIVATE
 
 PUBLIC INIT_RADIATION,COMPUTE_RADIATION,BLACKBODY_FRACTION, GET_KAPPA