Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyrolysis Simulation Time #6848

Closed
johodges opened this issue Sep 26, 2018 · 5 comments
Closed

Pyrolysis Simulation Time #6848

johodges opened this issue Sep 26, 2018 · 5 comments
Assignees

Comments

@johodges
Copy link
Collaborator

johodges commented Sep 26, 2018

This input file results in a significant difference in the computational time between FDS version 6.2 and FDS version 6.7. From the output files it seems the majority of the difference is in the wall routine. The total run time on my machine in 6.2 is 33 seconds versus 410 seconds in 6.7. The input file is simulating ignition through a cone test.

pyroSimTime.zip

@mcgratta mcgratta self-assigned this Sep 26, 2018
mcgratta added a commit to mcgratta/fds that referenced this issue Sep 26, 2018
…f solid cells when SPECIFIC_HEAT is ramped.
mcgratta added a commit that referenced this issue Sep 26, 2018
FDS Source: Issue #6848. Fix bug in calculation of number of solid ce…
@mcgratta
Copy link
Contributor

This should be fixed. Recompile the latest source code and let me know if the problem is fixed.

@johodges
Copy link
Collaborator Author

johodges commented Oct 2, 2018

Thanks for looking into this issue. I compiled the latest version and re-ran the comparison. The wall time is lower but the DIVG, MASS, and VELO times are higher than before. Please see the attached output/cpu files.
comparisonzip.zip

@mcgratta
Copy link
Contributor

mcgratta commented Oct 2, 2018

Your new times are much higher. Are you sure you compiled the release, as opposed to debug, version. When I run the case, it is slightly slower than the 6.2 times, but probably just because of a difference in processor speed.

@johodges
Copy link
Collaborator Author

johodges commented Oct 3, 2018

Thanks for pointing that out, the increase in other times was a result of compiling the debug version. When I run the comparison with the release version the times are comparable. Thanks for the support.

@mcgratta
Copy link
Contributor

mcgratta commented Oct 3, 2018

No problem. You caught a nasty bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants