Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVAC 'Leak' FDS 6.3.4/6.4.0 #3930

Closed
cfaurie opened this issue Jun 9, 2016 · 10 comments
Closed

HVAC 'Leak' FDS 6.3.4/6.4.0 #3930

cfaurie opened this issue Jun 9, 2016 · 10 comments
Assignees

Comments

@cfaurie
Copy link

cfaurie commented Jun 9, 2016

Hello,

In the FDS 6.4.0 Release Note, there is a point about the HVAC 'Leak' submodel, "Fixed bug in HVAC bc for leakage vents. Inflow and outflow boundaries are handled with slightly different logic and the HVAC model was not appropriately selecting the correct set of logic.". Can you explain a bit more what this is referring to? Couldn't find anything in the UG or TG.

The exact same very simple input file (fire in a room with sufficient ventilation + door with a small leakage area at the top) run with FDS 6.3.4 and FDS 6.4.0 gives quite different results, see visibility slices below:
image

Thanks for your help,
Coraline

@drjfloyd drjfloyd self-assigned this Jun 9, 2016
@drjfloyd
Copy link
Contributor

drjfloyd commented Jun 9, 2016

This was a bug fix. The description of the model in the Tech Guide and the inputs to the model in the User's Guide did not change. The model as described was not correctly implemented. There was an error in how the connection from an HVAC duct to the FDS domain was being handled. That error was fixed.

Since I don't know your model inputs, I don't know what I should expect to see to able to draw any conclusions from your images. If you believe that 6.4.0 is incorrect please add an input file and describe what you expect to see.

@cfaurie
Copy link
Author

cfaurie commented Jun 9, 2016

The temperature in the fire room exceeds 300 degC rapidly (my fire is instantaneous just for verification purpose), so I'd expect the smoke leaking from the top of the door to be hot, and therefore to rise as FDS 6.3.4 predicts.

The smoke out of the door is indeed hot at the beginning of the simulation, but seems to suddenly snap back to 20 degC after around 25 s with FDS 6.4.0. I'm not sure why. The NODE TEMPERATURE device that I set up says the contrary, with an outflow temperature at around 300 degC, as expected, for both versions of FDS.
Defect.txt

I've attached the input file.

Thanks,
Coraline

@drjfloyd
Copy link
Contributor

drjfloyd commented Jun 9, 2016

I'll take a look.

@drjfloyd
Copy link
Contributor

drjfloyd commented Jun 9, 2016

I am seeing the same behavior. Something definitely seems to be wrong.

@cfaurie
Copy link
Author

cfaurie commented Jun 10, 2016

You probably already noticed it, but I of course meant FDS version 6.3.2, sorry. Let me know if I can help!

drjfloyd added a commit that referenced this issue Jun 12, 2016
FDS Source: Fix Issue #3930 use ZZ for duct and not gas for Q_LEAK
@drjfloyd
Copy link
Contributor

Fixed. The issue was computing the leak enthalpy as T_DUCT_CP(T_DUCT,ZZ_DUCT)-T_GAS_CP(T_GAS,ZZ_GAS) instead of T_DUCT_CP(T_DUCT,ZZ_DUCT)-T_GAS_CP(T_GAS,ZZ_DUCT).

firemodels/fds-smv@a05e5aa

@cfaurie
Copy link
Author

cfaurie commented Jun 13, 2016

Great thanks. I suppose the fix will be available in the next release?

Do both versions of FDS show the same results now?

@drjfloyd
Copy link
Contributor

Yes it will be in the next release. With the fix, the smoke remains hot.

@mcgratta
Copy link
Contributor

mcgratta commented Jul 7, 2016

The new release is out. Can you test your case.

@drjfloyd
Copy link
Contributor

Tested with the release and fix is still working. Closing the issue.

gforney pushed a commit to gforney/fds that referenced this issue Feb 14, 2024
… Q_LEAK

Former-commit-id: b9b4239ac62165cbb77d1be9c03376f73c3a3fa3 [formerly a9b7027f14ffa3a4018430b75d862b9911be8595]
Former-commit-id: 861eadbd2c3b8cbc2f26a65014171a19d7e65bb9
Former-commit-id: 7aa7e7b
gforney pushed a commit to gforney/fds that referenced this issue Feb 14, 2024
FDS Source: Fix Issue firemodels#3930 use ZZ for duct and not gas for Q_LEAK

Former-commit-id: dce1b67c5e954efe2fc0c092f43418beed0c5db1 [formerly a482e882060e185848353ba529be375f7111271a]
Former-commit-id: db279c0b018bd7f3c50b69d7a6cf526a9070c21d
Former-commit-id: 57b333d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants