Fix PHP Recoverable Error in cron job. Move database code to resource mo... #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model and do not load logs into memory before deleting them.
|
Hi thanks, can you make a pull request for the "develop" branch? |
|
It is a hotfix so seems to make sense to put on master and then merge into develop.. |
daim2k5
added a commit
that referenced
this pull request
Sep 28, 2013
Fix PHP Recoverable Error in cron job. Move database code to resource mo...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...del and do not load logs into memory before deleting them.
I started getting this error after updating:
Also the method of deleting could quite easily run out of memory if the logs got flooded somehow and was generally very inefficient. Loaded all logs into collection with full-blow models and delete individually while not actually reading any of the data..