Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow composer installation with php 8.x #44

Merged
merged 1 commit into from
May 12, 2023

Conversation

smagdziarz
Copy link

This pull request is intended to make it possible to install the extension with Magento 2.4.6 and PHP 8.2, I did not test the actual compatibility of the module with PHP 8.2.

@smagdziarz smagdziarz marked this pull request as ready for review May 12, 2023 11:19
@smagdziarz smagdziarz mentioned this pull request May 12, 2023
@sprankhub
Copy link
Member

At least a basic phpcs check does not find anything:

$ vendor/bin/phpcs --standard=PHPCompatibility -p src/FireGento/ExtendedImport2/ --runtime-set testVersion 8.2
..... 5 / 5 (100%)


Time: 53ms; Memory: 14MB

Hence, let's merge this and see what happens 😂

@sprankhub sprankhub merged commit 5557f54 into firegento:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants