Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB as Debit indicator #686

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Add DB as Debit indicator #686

merged 1 commit into from
Oct 20, 2024

Conversation

akhy
Copy link
Contributor

@akhy akhy commented Oct 20, 2024

In Bank BCA (indonesia), the statement uses DB for indicating Debit and CR for Credit

Sorry for the wrong target branch in prev PR, it seems cannot be changed so I recreated it.

Changes in this pull request:

  • add "db" as one of debit/negative generic indicator

@JC5

In Bank BCA (indonesia), the statement uses DB for indicating Debit and CR for Credit
@akhy akhy requested a review from JC5 as a code owner October 20, 2024 15:23
@JC5 JC5 merged commit fc56418 into firefly-iii:develop Oct 20, 2024
2 checks passed
@JC5
Copy link
Member

JC5 commented Oct 20, 2024

Nice, this will be part of the next release 👍

@akhy
Copy link
Contributor Author

akhy commented Oct 20, 2024

@JC5 thanks for merging it. Btw, is there any plan to make this indicator configurable via UI/config file instead of hardcoding it?

@akhy akhy deleted the patch-1 branch October 20, 2024 19:59
@JC5
Copy link
Member

JC5 commented Oct 21, 2024

Yes, but it doesn't have a lot of priority. It doesn't happen that often :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants