Fix locate_cell changing coordinates dat version #2780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, running this
prints
This incrementation by two happens in
MeshGeometry.locate_cell_and_reference_coordinate
when accessingself.coordinates._ctypes
firedrake/firedrake/mesh.py
Line 1892 in 191c339
The root cause of this is at this line
firedrake/firedrake/function.py
Line 459 in 191c339
and this line
firedrake/firedrake/function.py
Line 459 in 191c339
This PR fixes this by switching to accessing
data_ro
instead ofdata
.