add initrd option #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Coulter <mjc@sekurity.org>
Kern--
reviewed
Apr 22, 2022
options.go
Outdated
| @@ -40,6 +40,7 @@ type options struct { | |||
| FcBinary string `long:"firecracker-binary" description:"Path to firecracker binary"` | |||
| FcKernelImage string `long:"kernel" description:"Path to the kernel image" default:"./vmlinux"` | |||
| FcKernelCmdLine string `long:"kernel-opts" description:"Kernel commandline" default:"ro console=ttyS0 noapic reboot=k panic=1 pci=off nomodules"` | |||
| FcInitrdPath string `long:"initrd-path" description:"path to initrd" default:"./initramfs"` | |||
There was a problem hiding this comment.
3 comments:
- Since this is optional, I don't think we should have a default.
- We don't suffix other options with
path, I think the field name and arg name should just beFcInitrdandinitrdrespectively. - Nitpick: capitalize the first letter of the description (i.e. "Path")
There was a problem hiding this comment.
Thanks for the feedback, pushed up a fix for all 3 points.
Signed-off-by: Michael Coulter <mjc@sekurity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Coulter mjc@sekurity.org
This adds an option to specify an initrd for firecracker via
--initrd-path.Not sure if the default is what's preferred or if some tests need to be added, but this was enough to be useful my own use case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.