Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep between retries during UFFD handler negotiation #5103

Merged

Conversation

bchalios
Copy link
Contributor

@bchalios bchalios commented Mar 21, 2025

Changes

Add a small timeout between retries during UFFD negotiation between handler and Firecracker.

Reason

During fc85170, we changed the UFFD handler logic to retry the negotiation with Firecracker up to 5 times in case of failures. Retries happen immediately.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@bchalios bchalios self-assigned this Mar 21, 2025
@bchalios bchalios added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 21, 2025
@bchalios bchalios enabled auto-merge (rebase) March 21, 2025 11:31
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (aa73f45) to head (73171c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5103   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files         248      248           
  Lines       26925    26925           
=======================================
  Hits        22388    22388           
  Misses       4537     4537           
Flag Coverage Δ
5.10-c5n.metal 83.53% <ø> (ø)
5.10-m5n.metal 83.52% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.71% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 79.57% <ø> (ø)
5.10-m6i.metal 83.51% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.71% <ø> (?)
5.10-m7g.metal 79.57% <ø> (ø)
6.1-c5n.metal 83.57% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.56% <ø> (ø)
6.1-m6a.metal 82.75% <ø> (ø)
6.1-m6g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m6i.metal 83.55% <ø> (ø)
6.1-m7a.metal-48xl 82.75% <ø> (?)
6.1-m7g.metal 79.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

During fc85170, we changed the UFFD handler logic to retry the
negotiation with Firecracker up to 5 times in case of failures. Retries
happen immediately. Add a small timeout between retries to make this
even more robust.

Signed-off-by: Babis Chalios <bchalios@amazon.es>
@bchalios bchalios force-pushed the more_robust_uffd_handlers branch from 9c5f28c to 73171c1 Compare March 21, 2025 11:41
@bchalios bchalios merged commit 69522c8 into firecracker-microvm:main Mar 21, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants