-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-release doc updates and other miscellanea #5091
Post-release doc updates and other miscellanea #5091
Conversation
We need to manually change what versions our quick start guide points to at every release. To avoid it getting behind, this change adds automatic detection of the CI artifacts related to the lastest version (which was already automatically detected). This means that CI artifacts will not point to the latest available but they will be the same we use to test the latest release, to ensure compatibility and that the guide always works. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5091 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 248 248
Lines 26923 26923
=======================================
Hits 22386 22386
Misses 4537 4537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated the new getting started guide works on my laptop 🎉
The current wording is unclear since all kernel versions seem to be expired or to expire this year. This commit attempts to make it clear that 2 versions will always be supported. Furthermore, any reference to 4.14 is removed. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
We changed the markdown format of CHANGELOG.md to not have escapes for the square brackets, so the tool broke. This commit fixes it. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
a38be69
to
b2276da
Compare
Add 1.11 to the release policy and mark 1.9 as unsupported. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
It was incorrectly marked as released in 1.11.0. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
This commit updates the CREDITS.md file to be in sync with the new release v1.11.0 Signed-off-by: Riccardo Mancini <mancio@amazon.com>
b2276da
to
fbe0763
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes.
Changes
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.